Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google calendars where the user has write access #49

Merged

Conversation

surfing
Copy link
Contributor

@surfing surfing commented Sep 15, 2015

Add google calendars where the user has write access but is not the owner.
This gives access to all shared google calendars where the user has full access.
See #36

@chriadam
Copy link
Contributor

LGTM. I wonder whether we should provide UI during account-creation phase which lets the user select which calendars they wish to sync? But for now, I think this is fine.

@antseppa @pvuorela any concerns?

@pvuorela
Copy link
Contributor

No concerns on my side. Good to have this.

For selecting calendars, in case user disables some in the Calendar app, is the unnecessary traffic really that much it would matter? In case we actually want to disable syncing for some, maybe that could be connected to enabled visibility.

@surfing
Copy link
Contributor Author

surfing commented Sep 16, 2015

After this patch I can try to implement calendars with read access only. Is this a feature you would accept, too?

@chriadam
Copy link
Contributor

Read-only can be tricky to get right due to strange semantics enforced by mkcal. E.g., if a notebook is marked as read-only, and you attempt to add a new (synced) event to it, the event will be inserted into the database with a null notebook field, effectively becoming an immediate orphan event.

I have no issue with you implementing the feature - it would be useful. However, I would need to be convinced that it doesn't accidentally introduce some subtle bugs in some codepath, before I'd accept it into the repo.

@surfing
Copy link
Contributor Author

surfing commented Sep 17, 2015

okay, so I think I will first try to add some tests to this project and afterwards some to the mkcal project. I think there is no other way to convince you.

@chriadam
Copy link
Contributor

Thank you very much, that would be great appreciated!

chriadam pushed a commit that referenced this pull request Sep 17, 2015
Add google calendars where the user has write access
@chriadam chriadam merged commit 5afd178 into nemomobile:master Sep 17, 2015
@palikao
Copy link

palikao commented Dec 12, 2015

I agree, shared calendars are needed, at list only view mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants