Merge pull request #1556 from maxhelias/reflection-method

Use getReflectionMethod instead of getReflactionClassAndMethod
nelmio · Nov 21, 2019 · f596adf · f596adf
2 parents e9cdde1 + aa1432f
commit f596adf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 19 deletions.
diff --git a/Describer/SwaggerPhpDescriber.php b/Describer/SwaggerPhpDescriber.php
@@ -229,8 +229,7 @@ private function getMethodsToParse(): \Generator
             }
 
             $controller = $route->getDefault('_controller');
-            if ($callable = $this->controllerReflector->getReflectionClassAndMethod($controller)) {
-                list($class, $method) = $callable;
+            if ($method = $this->controllerReflector->getReflectionMethod($controller)) {
                 $path = $this->normalizePath($route->getPath());
                 $httpMethods = $route->getMethods() ?: Swagger::$METHODS;
                 $httpMethods = array_map('strtolower', $httpMethods);

diff --git a/Util/ControllerReflector.php b/Util/ControllerReflector.php
@@ -59,23 +59,6 @@ public function getReflectionMethod(string $controller)
         }
     }
 
-    public function getReflectionClassAndMethod(string $controller)
-    {
-        $callable = $this->getClassAndMethod($controller);
-        if (null === $callable) {
-            return;
-        }
-
-        list($class, $method) = $callable;
-
-        try {
-            return [new \ReflectionClass($class), new \ReflectionMethod($class, $method)];
-        } catch (\ReflectionException $e) {
-            // In case we can't reflect the controller, we just
-            // ignore the route
-        }
-    }
-
     private function getClassAndMethod(string $controller)
     {
         if (isset($this->controllers[$controller])) {