-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide gallery without exhibits #20
Hide gallery without exhibits #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, some minor suggestions.
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more suggestion. Before releasing we will want to make a PR to nebari
so that it sets hide_gallery_without_exhibits
.
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Reference Issues or PRs
Fixes #18
What does this implement/fix?
Adds a configuration setting
hideGalleryWithoutExhibits
. When set to True and no exhibits are configured, the gallery panel will not be displayed in JupyterLab. When set to False, the gallery will be displayed whether any exhibits are configured or not. By default it is set to False.Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?