Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide gallery without exhibits #20

Merged

Conversation

andrewfulton9
Copy link
Collaborator

Reference Issues or PRs

Fixes #18

What does this implement/fix?

Adds a configuration setting hideGalleryWithoutExhibits. When set to True and no exhibits are configured, the gallery panel will not be displayed in JupyterLab. When set to False, the gallery will be displayed whether any exhibits are configured or not. By default it is set to False.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@andrewfulton9 andrewfulton9 requested a review from krassowski June 18, 2024 18:16
Copy link

Binder 👈 Launch a Binder on branch andrewfulton9/jupyterlab-gallery/hide_gallery_without_exhibits

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, some minor suggestions.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
jupyterlab_gallery/manager.py Outdated Show resolved Hide resolved
andrewfulton9 and others added 4 commits June 20, 2024 11:34
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more suggestion. Before releasing we will want to make a PR to nebari so that it sets hide_gallery_without_exhibits.

jupyterlab_gallery/manager.py Outdated Show resolved Hide resolved
jupyterlab_gallery/handlers.py Outdated Show resolved Hide resolved
andrewfulton9 and others added 2 commits June 25, 2024 15:41
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
@krassowski krassowski merged commit 2d7e5c9 into nebari-dev:main Jun 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the gallery section be hidden in the launcher if no exhibits are configured?
2 participants