Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream breaking up, fix blocking of JupyterLab load on repository fetch #14

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jun 10, 2024

Reference Issues or PRs

Progress bar now shows progress also:

  • after refreshing browser
  • when multiple tabs are open
  • within initial 0.1s in worst case (previously 0.5s)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@krassowski krassowski added the bug label Jun 10, 2024
Copy link

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-gallery/fix-progress-bar-issues

- after refreshing browser
- when multiple tabs are open
- for initial 0.5s in worst case (now 0.1s)
also fix the state not being fully reflected after refresh
@krassowski krassowski force-pushed the fix-progress-bar-issues branch from 37c1b76 to 559971f Compare June 11, 2024 14:44
@krassowski krassowski force-pushed the fix-progress-bar-issues branch from f6e05d0 to f4a87d9 Compare June 11, 2024 14:54
@krassowski krassowski changed the title Fix progress bar not showing progress in a few cases Fix stream breaking up, fix blocking of JupyterLab load on repository fetch Jun 11, 2024
@krassowski krassowski merged commit d14bc00 into main Jun 11, 2024
7 checks passed
@krassowski krassowski deleted the fix-progress-bar-issues branch June 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant