Impr docs #1262
Open
Impr docs #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 80.06% 80.06%
=======================================
Files 104 104
Lines 14855 14855
=======================================
Hits 11893 11893
Misses 2962 2962 ☔ View full report in Codecov by Sentry. |
dj8yfo
reviewed
Nov 29, 2024
near-sdk/src/environment/env.rs
Outdated
| @@ -500,6 +500,8 @@ pub fn alt_bn128_pairing_check(value: &[u8]) -> bool { | |||
| // ################ | |||
| /// Creates a promise that will execute a method on account with given arguments and attaches | |||
| /// the given amount and gas. | |||
There was a problem hiding this comment.
@PolyProgrammist suggest adding more links, mentioned in #1265 and marked up in review of #1259,
in addition to ones, added in scope of current pr, after fixing conflicts, if you plan to finish current pr
There was a problem hiding this comment.
Which links do you mean? @dj8yfo
There was a problem hiding this comment.
Added half of the comments. Left the other for the future
denbite
reviewed
Dec 11, 2024
PolyProgrammist
requested review from
frol,
ruseinov and
akorchyn
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.