Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have #[handle_result] support Result types reardless of how they're referred to #1099

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Have #[handle_result] support Result types reardless of how they're referred to #1099

merged 4 commits into from
Oct 22, 2023

Conversation

iho
Copy link
Contributor

@iho iho commented Oct 20, 2023 •
edited
Loading

Port of #1057 to syn2

@iho iho changed the title Have #[handle_result] support Result types reardless of how they're r… Have #[handle_result] support Result types reardless of how they're referred to Oct 20, 2023
@iho iho marked this pull request as ready for review October 20, 2023 15:39
@iho iho requested review from frol, agostbiro and uint as code owners October 20, 2023 15:39
uint
uint approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frol frol merged commit ee5cf86 into near:master Oct 22, 2023
12 of 13 checks passed
@frol frol mentioned this pull request Oct 22, 2023
Closed
@frol frol mentioned this pull request Oct 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uint uint uint approved these changes

@frol frol Awaiting requested review from frol frol is a code owner

@agostbiro agostbiro Awaiting requested review from agostbiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iho @uint @frol