Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move from Gas to NearGas from near-gas crate #1082

Merged
merged 13 commits into from
Sep 24, 2023
Merged

refactor: Move from Gas to NearGas from near-gas crate #1082

merged 13 commits into from
Sep 24, 2023

Conversation

iho
Copy link
Contributor

@iho iho commented Sep 13, 2023

No description provided.

frol
frol approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! See some proposed fixes in the comments

examples/factory-contract/low-level/src/lib.rs Outdated Show resolved Hide resolved
examples/fungible-token/test-contract-defi/src/lib.rs Show resolved Hide resolved
examples/non-fungible-token/test-approval-receiver/src/lib.rs Outdated Show resolved Hide resolved
examples/non-fungible-token/test-token-receiver/src/lib.rs Outdated Show resolved Hide resolved
near-contract-standards/src/fungible_token/core_impl.rs Outdated Show resolved Hide resolved
near-contract-standards/src/fungible_token/core_impl.rs Outdated Show resolved Hide resolved
near-contract-standards/src/fungible_token/core_impl.rs Outdated Show resolved Hide resolved
near-contract-standards/src/non_fungible_token/approval/approval_impl.rs Outdated Show resolved Hide resolved
near-contract-standards/src/non_fungible_token/core/core_impl.rs Outdated Show resolved Hide resolved
near-contract-standards/src/non_fungible_token/core/core_impl.rs Outdated Show resolved Hide resolved
@iho iho marked this pull request as ready for review September 15, 2023 13:09
@iho iho requested review from agostbiro and uint as code owners September 15, 2023 13:09
@iho iho changed the title WIP Move from Gas to NearGas from near-gas crate Move from Gas to NearGas from near-gas crate Sep 17, 2023
frol
frol approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR is good to go once new version of near-gas is released.

@frol frol changed the title Move from Gas to NearGas from near-gas crate refactor: Move from Gas to NearGas from near-gas crate Sep 24, 2023
@frol frol enabled auto-merge (squash) September 24, 2023 18:49
@frol frol merged commit 7e15af9 into near:master Sep 24, 2023
13 checks passed
@frol frol mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iho @frol