Add test case for Vector with borsh serializer #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new test case to verify that Near collections (Vector, LookupMap, etc) are correctly serialized and deserialized using the borsh serializer.
ailisp
reviewed
Jul 24, 2024
|
|
||
| const message: PostedMessage = { premium, sender, text }; | ||
| this.messages.push(message, { | ||
| serializer: (value) => borsh.serialize(MessageSchema, value), |
There was a problem hiding this comment.
This is a manual serialization, can we make use of above
@NearBindgen({
serializer(value) {
return borsh.serialize(schema, value);
},
to auto serialize?
There was a problem hiding this comment.
didn't catch that, could you clarify?
ailisp
reviewed
Jul 24, 2024
|
|
||
| @NearBindgen({ | ||
| serializer(value) { | ||
| return borsh.serialize(schema, value); |
There was a problem hiding this comment.
schema is not defined, would result in error
There was a problem hiding this comment.
schema is defined in the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Added a new test case (based on GuestBook contract) to verify that Near collections (Vector, LookupMap, etc) are correctly serialized and deserialized using the borsh
Test Plan
Related issues/PRs
#402