Add suggestions for all relevant JS commands #345

garikbesson · 2024-05-23T15:58:55Z

The PR contains fixes of suggestions for new syntax of commands when users try to run commands with old (JS) syntax
Integration tests are committed only on purpose to review and test the PR. They should be removed before merging.

src/js_command_match/add_credentials.rs

src/js_command_match/add_key.rs

frol · 2024-06-18T07:05:31Z

Please, resolve the conflicts and rewrite integration tests into Rust:

If you are new to integration tests in Rust, Rust book has a great chapter: https://doc.rust-lang.org/book/ch11-03-test-organization.html#integration-tests (tip: don't miss the section called "Integration Tests for Binary Crates")

P.S. If you feel it is too much, let's call for help to rewrite the tests into Rust, just let me know

Co-authored-by: Vlad Frolov <[email protected]>

… aliases to separated file

garikbesson · 2024-07-02T15:24:29Z

@frol Hi, could you review the PR again?

That's key things that have changed since the last review:

I removed end-to-end tests written by me in JavaScript
I implemented unit tests that parse args and check how the interpreted commands look like
I skipped some following methods that are deprecated on JS CLI: clean, dev-deploy, evm-call, evm-view, evm-dev-init, js, repl, set-api-key
I skipped validator-related methods: proposals, stake, validators
All interpreted commands now leverage sign-with-keychain option (instead of leveraging the legacy keychain)

CC: @gagdiez

I re-organized the files following the same structure we had in the NEAR CLI so it is easier to map them 1:1 and thus evaluate them. I further updated all commands to use the same nomenclature than used on NEAR CLI. Finally, I removed the commands that have been deprecated for a while, since anyways there is two options: - Either they are migrating from a tool from were they were already deprecated - They are new to the tool, and thus what is deprecated or not is not important

gagdiez

I have tested all codes and its variants, and the proposed commands work accordingly

src/js_command_match/transactions/status.rs

src/js_command_match/keys/list.rs

src/js_command_match/keys/add.rs

src/js_command_match/contract/call.rs

Co-authored-by: Vlad Frolov <[email protected]>

src/js_command_match/account/create.rs

src/js_command_match/constants.rs

garikbesson · 2024-07-09T14:20:13Z

@race-of-sloths please, include my PR in the Race

race-of-sloths · 2024-07-09T14:21:36Z

@garikbesson Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Current status: executed

Reviewer	Score
@frol	13

The average score is 13

@garikbesson check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors
- Include a PR: @race-of-sloths include to enter the Race with your PR
For maintainers:
- Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
- Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
- Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

…nd 'validator-stake' aliases)

frol

@garikbesson @gagdiez Enormous effort! Thank you for pulling it out!

@race-of-sloths score 13

race-of-sloths · 2024-07-09T21:39:03Z

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

## 🤖 New release * `near-cli-rs`: 0.11.1 -> 0.12.0 <details><summary>Changelog</summary> <blockquote> ## [0.12.0](v0.11.1...v0.12.0) - 2024-07-09 ### Added - Cover *all* commands from near-cli JS with the new near-cli-rs suggestions for full compatibility ([#345](#345)) - Added the ability to select HD Path from the ledger ([#362](#362)) - Added loading indicators for "transaction" group commands and improved the prompt messages ([#358](#358)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).

race-of-sloths · 2024-07-10T21:46:34Z

✅ PR is finalized!

Your contribution is much appreciated with a final score of 13!
You have received 150 (130 base + 10 weekly bonus + 10 monthly bonus) Sloth points for this contribution

Congratulations @garikbesson! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

initial fixing suggested commands for js versions + test

228a8a3

frol marked this pull request as draft May 26, 2024 18:28

garikbesson and others added 9 commits June 4, 2024 17:39

building suggestion for js version of commands

6acbce5

account creation tests + fixes

6fc63a8

tests for deleting account

447807f

updated test framework

a761226

fix regex in tests

c61b700

tests for checking storage/state functions

f8b59b4

contract, key actions testcases, fixed delete_key and deploy functions

63dbdbb

credentials, keys and near actions tests

fe10614

removed debug logs

8153485

frol requested changes Jun 18, 2024

View reviewed changes

src/js_command_match/add_credentials.rs Outdated Show resolved Hide resolved

src/js_command_match/add_credentials.rs Outdated Show resolved Hide resolved

src/js_command_match/add_key.rs Outdated Show resolved Hide resolved

gagdiez and others added 11 commits June 19, 2024 12:17

Update src/js_command_match/add_credentials.rs

437037b

Co-authored-by: Vlad Frolov <[email protected]>

Update src/js_command_match/add_credentials.rs

42d3305

Co-authored-by: Vlad Frolov <[email protected]>

experimental JS commands translation

7579ca2

refactored the unit-test to use clap::Parser

c0d8ce5

using keychain for creating account (js syntax)

1fdac41

CreateAccountArgs::to_cli_args unit tests

388a7d3

removed integration js tests, added add_credentials unit tests, moved…

50b13c3

… aliases to separated file

AddKeyArgs::to_cli_args unit tests

38345ea

CallArgs::to_cli_args unit tests

b68e151

DeleteAccountArgs::to_cli_args unit tests

0b74e6a

[...]Args::to_cli_args unit tests

bceba36

gagdiez added 4 commits July 4, 2024 13:30

chore: format files

63f10a4

fix: various commands

b1b6835

fix: merge conflict

c31b332

gagdiez changed the title ~~WIP: fixing suggested commands for js versions~~ Add suggestions for all relevant JS commands Jul 5, 2024

gagdiez requested a review from frol July 5, 2024 14:22

gagdiez previously approved these changes Jul 5, 2024

View reviewed changes

frol requested changes Jul 5, 2024

View reviewed changes

Apply suggestions from code review

8900733

Co-authored-by: Vlad Frolov <[email protected]>

gagdiez dismissed their stale review via 8900733 July 5, 2024 17:59

apply code suggestions

26521a3

gagdiez requested a review from frol July 5, 2024 19:00

frol added 2 commits July 6, 2024 00:43

minor refactoring

be125ee

suggestion for refactoring (two options)

e594f6f

frol force-pushed the fix-js-commands branch from 76dfb07 to e594f6f Compare July 5, 2024 22:46

frol reviewed Jul 6, 2024

View reviewed changes

src/js_command_match/account/create.rs Outdated Show resolved Hide resolved

frol requested changes Jul 7, 2024

View reviewed changes

src/js_command_match/constants.rs Outdated Show resolved Hide resolved

src/js_command_match/constants.rs Outdated Show resolved Hide resolved

garikbesson and others added 8 commits July 8, 2024 14:36

apply minor fixes after review

9e0fb9a

refactored suggestions unit tests

24cff01

wip

46da562

Merge branch 'main' into fix-js-commands

cabe809

feat: add path to use-ledger

0ee1f8e

fix: aliases and style

b02c2d0

more code style fixes

0d4b4dd

fixes aliases indexes in unit tests

ef37494

tested JS commands aliases (added missing 'keys', 'import-account', a…

45e983b

…nd 'validator-stake' aliases)

frol approved these changes Jul 9, 2024

View reviewed changes

frol enabled auto-merge (squash) July 9, 2024 21:39

frol merged commit d5839d0 into near:main Jul 9, 2024
7 checks passed

frol mentioned this pull request Jul 6, 2024

chore: release v0.12.0 #363

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add suggestions for all relevant JS commands #345

Add suggestions for all relevant JS commands #345

garikbesson commented May 23, 2024 •

edited

Loading

frol commented Jun 18, 2024

garikbesson commented Jul 2, 2024

gagdiez left a comment

garikbesson commented Jul 9, 2024

race-of-sloths commented Jul 9, 2024 •

edited

Loading

frol left a comment

race-of-sloths commented Jul 9, 2024

race-of-sloths commented Jul 10, 2024

Add suggestions for all relevant JS commands #345

Add suggestions for all relevant JS commands #345

Conversation

garikbesson commented May 23, 2024 • edited Loading

frol commented Jun 18, 2024

garikbesson commented Jul 2, 2024

gagdiez left a comment

Choose a reason for hiding this comment

garikbesson commented Jul 9, 2024

race-of-sloths commented Jul 9, 2024 • edited Loading

frol left a comment

Choose a reason for hiding this comment

race-of-sloths commented Jul 9, 2024

🌟 Score recorded!

race-of-sloths commented Jul 10, 2024

✅ PR is finalized!

garikbesson commented May 23, 2024 •

edited

Loading

race-of-sloths commented Jul 9, 2024 •

edited

Loading