Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mods public in lib.rs #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mikedotexe
Copy link

There are mods like transactions, contract, account… which contain useful information to use for folks integrating. Real quick PR to make those public, since I saw this error:

Screenshot 2024-11-23 at 12 18 47 AM

@akorchyn
Copy link
Collaborator

You don't need that struct. It's intermediate builder. Use
Transaction::construct(..)

@frol
Copy link
Contributor

frol commented Dec 3, 2024

@akorchyn I would really love to have some useful entry point in the root of the crate and kill prelude. We only have a few structs, not a gazillion of them and no traits afaik. I'd love to open https://docs.rs/near-api/latest/near_api/ and see the menu similar to the one in near.cli.rs, so as a developer I can quickly identify my next step. Similar to https://docs.rs/near-api/latest/near_api/prelude/index.html, but maybe an even more slimmed-down one.

@akorchyn
Copy link
Collaborator

If you don't mind I would keep them private for now. Not sure if it's necessary.
But if you think that it might bring more value to have everything pub, I would love to hear that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants