Internal LB #321
Merged
Internal LB #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kmaus-near creating this PR for visibility |
|
@itegulov @volovyks this PR is quite large, let me give some context: I separated dev and prod environments for ease of provisioning internal LBs for testnet and mainnet separate from the dev environment cloudrun services. Before we merge this, the service account that runs GHA pipelines needs to have access permissions to pagoda-shared-infrastructure VPC networks, as we are adding these cloudrun services to Pagoda's internal network in order to utilize the domain names from #250 and have the Prod services only accessible via Kong API gateway (Domains).
Please take a look at this PR and make any suggestions or call out any mistakes, if need feel free to throw a meeting invite on the calendar. |
|
I removed the DEV GHA pipeline, let's just keep what you guys have as discussed in our call. The Prod pipeline is manually triggered for testnet/mainnet. Do we know which service account is responsible for deploying the feature environments? I need to give it access to the shared VPC networks in order for it to deploy terraform. |
|
Thinking out loud here, should we add a version tag for mainnet/testnet releases? This way we can manually roll back if any issues occur. |
It should be
Yeah sounds like a good idea |
Terraform Feature Environment (dev-321)Terraform Initialization ⚙️
|
volovyks
commented
Nov 14, 2023
There was a problem hiding this comment.
I can not technically approve this PR, because I've created it :/ So.. Approved :)
I would add a list of our envs with their proper names and a small 1-sentence description of each env purpose.
Definitely not a blocker now, but it would be nice to get rid of config duplication, especially in deployment scripts.
itegulov
previously approved these changes
Nov 14, 2023
…mpc-recovery into kmaus-near/add-internal-lb
kmaus-near
previously approved these changes
Nov 14, 2023
kmaus-near
previously approved these changes
Nov 14, 2023
kmaus-near
previously approved these changes
Nov 14, 2023
kmaus-near
approved these changes
Nov 14, 2023
Terraform Feature Environment Destroy (dev-321)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.