Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy.md #1476

Closed
wants to merge 1 commit into from
Closed

Update deploy.md #1476

wants to merge 1 commit into from

Conversation

ghimire007
Copy link
Contributor

use near-cli-rs instead of JS version

use near-cli-rs instead of JS version
@ghimire007 ghimire007 requested a review from bucanero as a code owner September 2, 2023 03:50
@gagdiez
Copy link
Collaborator

gagdiez commented Sep 2, 2023

While I agree that we need to add more information on the updated near-cli-rs, we need to be careful on how we do it. There has been no announce that the classic near cli is being deprecated, and even if there was, we cannot just eradicate de old tool since lots of people rely on it.

It is better to have only one PR to add near CLI across all docs, and to do so using the same "tabs" system we have for the SDKs.

@gagdiez gagdiez closed this Sep 2, 2023
@gagdiez gagdiez mentioned this pull request Sep 2, 2023
@ghimire007
Copy link
Contributor Author

ghimire007 commented Sep 2, 2023

This changes were made in response to raised issue here. It makes sense having tab based system like we have for js and rs sdk. what your take on this @frol ?

@frol
Copy link
Collaborator

frol commented Sep 2, 2023

Sure, let's go with tabs. In the future we will add cargo-near where applicable and make them the default where it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants