Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI / UX improvements #41

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

UI / UX improvements #41

wants to merge 27 commits into from

Conversation

thisisjoshford
Copy link
Member

@thisisjoshford thisisjoshford commented Oct 29, 2024

This PR makes several UI/UX improvements for this example.

  • Improved styling and formatting
  • Moved derived address & balance closer to input fields
  • Adds sepolia gas prices (testnet price spiked within past month and caused failures)

Before:
Screenshot 2024-11-25 at 1 17 33 PM

After:
Screenshot 2024-11-25 at 1 18 22 PM

@thisisjoshford thisisjoshford marked this pull request as ready for review November 25, 2024 21:14
@thisisjoshford thisisjoshford changed the title [WIP] UI / UX improvements UI / UX improvements Nov 25, 2024
@gagdiez
Copy link
Collaborator

gagdiez commented Nov 26, 2024

I like some changes, others I feel that are not necessary.

I like:

  • Showing the GAS
  • Being more explicit about the chain and address being derived

I don't feel they are needed:

  • Adding dark mode
  • Changing how the layout / form looks

Copy link
Collaborator

@gagdiez gagdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel that we need to add dark mode or change how the layout / form looks

@thisisjoshford
Copy link
Member Author

I don't feel that we need to add dark mode or change how the layout / form looks

Ok, I switched it back to light mode, but I do feel that this form looks more polished/professional no?

Screenshot 2024-11-26 at 10 22 22 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants