Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency for github.com/dgraph-io/ristretto/z #115

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Dec 29, 2023

dgraph-io/ristretto use google/glog. glog rewrites flags on its own, which causes unexpected behaviour.

For example:

package main

import (
	"flag"
	//_ "github.com/dgraph-io/ristretto/z"
)

func main() {
	flag.Parse()
}

depend on dgraph-io/ristretto

$ ./test -h
Usage of ./test:
  -alsologtostderr
    	log to standard error as well as files
  -log_backtrace_at value
    	when logging hits line file:N, emit a stack trace
  -log_dir string
    	If non-empty, write log files in this directory
  -logtostderr
    	log to standard error instead of files
  -stderrthreshold value
    	logs at or above this threshold go to stderr
  -v value
    	log level for V logs
  -vmodule value
    	comma-separated list of pattern=N settings for file-filtered logging

not depend on dgraph-io/ristretto

$ ./test -h
Usage of ./zz:

dgraph-io/ristretto use google/glog. glog rewrites flags on its own, which
causes unexpected behaviour.
Copy link

sweep-ai bot commented Dec 29, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@fiatjaf fiatjaf merged commit 8b1839b into nbd-wtf:master Dec 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants