- changes to config components to avoid runtime error if mail config not yet populated #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nbarrett
commented
Sep 22, 2024
nbarrett
commented
- app port changed from 5000 to 5001 to avoid conflicts on new mac
- npm run serenity-bdd-update done within Dockerfile not in step before serenity is run
nbarrett
force-pushed
the
fly-deploy
branch
6 times, most recently
from
eabcafd to
a768666
Compare
- tag and push latest first to allow pull earlier if testing locally - fly port number changed to 5001 - Removed webdriver-manager as this is not required - log CHROME_VERSION and CHROMEDRIVER_VERSION - Switch to using npx @puppeteer/browsers install - App port changed from 5000 to 5001 to avoid conflicts on new Mac - NPM run serenity-bdd-update done within Dockerfile not in step before serenity is run - Removed derivation of CHROMEDRIVER_PATH env - is injected now - standardised CHROME and CHROMEDRIVER variable names - reflected required changes in protractor.conf.js - Removed heroku build and config files - App config and bug fixes - Changes to config components to avoid runtime error if mail config not yet populated - Turned off logging on many endpoints
nbarrett
force-pushed
the
fly-deploy
branch
from
a768666 to
e118541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.