ENH: test build action test with visibility

naviqore · May 30, 2024 · 0ba2ef1 · 0ba2ef1
1 parent 266682a
commit 0ba2ef1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/logging/CMakeLists.txt b/logging/CMakeLists.txt
@@ -19,21 +19,23 @@ target_link_libraries(${PROJECT_NAME} PRIVATE spdlog::spdlog)
 if(WIN32)
     if(BUILD_SHARED_LIBS)
         target_compile_definitions(${PROJECT_NAME}
-                PRIVATE LOGGER_API=__declspec(dllexport)
+                PRIVATE "LOGGER_API=__declspec(dllexport)"
+                INTERFACE "LOGGER_API=__declspec(dllimport)"
         )
     else()
         target_compile_definitions(${PROJECT_NAME}
-                PUBLIC LOGGER_API
+                PUBLIC "LOGGER_API"
         )
     endif()
 else()
     if(BUILD_SHARED_LIBS)
         target_compile_definitions(${PROJECT_NAME}
-                PRIVATE LOGGER_API=__attribute__((visibility("default")))
+                PRIVATE "LOGGER_API=__attribute__((visibility(\"default\")))"
+                INTERFACE "LOGGER_API=__attribute__((visibility(\"default\"))"
         )
     else()
         target_compile_definitions(${PROJECT_NAME}
-                PUBLIC LOGGER_API
+                PUBLIC "LOGGER_API"
         )
     endif()
 endif()