Feature/nav 150 extract python viewer package #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename to snake_case - Comment out new features for query params to be compatible with service version 0.4.0
…velopment dependency in the project - Could be added later, directly into the pyproject.toml: [tool.flake8] max-line-length = 88 - pre-commit can be configured later, at the moment it has to be bypassed all the time, since is quite a heavy refactoring.
- Python entrypoint, should work independent of directory location. - Add watchdog, should increase performance, according to streamlit.
|
@clukas1, I think we could merge this and release the viewer with version 0.5.0? |
- Avoids missing of logo.
- Add __init__ files to sub packages. - Add new asset package. - Rename headers of pages.
- Update page descriptions. - Rename NAVIQORE_HOST_URL to NAVIQORE_SERVICE_URL.
clukas1
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a draft, there are errors from the refactoring...