CLEANUP: Refactor methods of setting ritems #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
26fb268 to
2470626
Compare
This comment was marked as resolved.
This comment was marked as resolved.
namsic
reviewed
Mar 26, 2024
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
ef3e0ff to
f1ab61b
Compare
namsic
approved these changes
Mar 27, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ing-eoking
force-pushed
the
ritem
branch
8 times, most recently
from
eed606d to
414953c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
์ง๊ธ ๊ตฌํ ๊ธฐ์ค์ผ๋ก๋ protocol ๊ฐ ์ฝ๋ ์ฐจ์ด๊ฐ ๊ฑฐ์ ์์ด์ ๋ถ๋ฆฌํ์ง ์์๋ ๋ ๊ฒ ๊ฐ์ต๋๋ค. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ing-eoking
force-pushed
the
ritem
branch
9 times, most recently
from
fc548b5 to
cb5ce60
Compare
This comment was marked as resolved.
This comment was marked as resolved.
jhpark816
reviewed
Apr 5, 2024
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
77ba1ea to
a4f8c9d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ing-eoking
force-pushed
the
ritem
branch
2 times, most recently
from
d99d920 to
9dab785
Compare
|
@jhpark816 @namsic
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
โจ๏ธ What I did
rlist๋ฅผ ์ถ๊ฐํ์ต๋๋ค.ritem_set_first/ritem_set_next,RTYPE๋ฅผ ์ ๊ฑฐํ์ต๋๋ค.add_ritem/add_ritem_mblck/add_ritem_einfo/add_ritem_hinfo๋ฅผ ์ถ๊ฐํ์ต๋๋ค.rlist์ ๋ฉ๋ชจ๋ฆฌ ๋ถ์กฑ ์ฒ๋ฆฌ๋ฅผ ์ถ๊ฐํ๋ฉด์ ์ผ๋ถ ์๋ฌ ํธ๋ค๋ง์ ์๋์ PR์ฒ๋ผ ํต์ผ์์ผฐ์ต๋๋ค.