INTERNAL: Rename update_filter to eflag_update #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Dec 18, 2024
libmemcached/collection.cc
Outdated
| memcached_return_t memcached_coll_update_filter_init(memcached_coll_update_filter_st *ptr, | ||
| const unsigned char *fvalue, | ||
| const size_t fvalue_length) | ||
| memcached_return_t memcached_coll_eflag_update_init(memcached_coll_update_filter_st *ptr, |
libmemcached/collection.cc
Outdated
| memcached_return_t memcached_coll_update_filter_set_bitwise(memcached_coll_update_filter_st *ptr, | ||
| const size_t fwhere, | ||
| memcached_coll_bitwise_t bitwise_op) | ||
| memcached_return_t memcached_coll_eflag_update_set_bitwise(memcached_coll_update_filter_st *ptr, |
jhpark816
reviewed
Dec 18, 2024
libmemcached/types.h
Outdated
| @@ -92,6 +92,7 @@ typedef struct memcached_coll_query_st memcached_bop_query_st; | |||
| typedef struct memcached_hexadecimal_st memcached_hexadecimal_st; | |||
| typedef struct memcached_mkey_st memcached_mkey_st; | |||
| typedef struct memcached_coll_eflag_filter_st memcached_coll_eflag_filter_st; | |||
| typedef struct memcached_coll_update_filter_st memcached_coll_eflag_update_st; | |||
There was a problem hiding this comment.
아래 형태가 되도록 구조체 이름도 변경합시다.
typedef struct memcached_coll_eflag_update_st memcached_coll_eflag_update_st;
typedef struct memcached_coll_eflag_update_st memcached_coll_update_filter_st;
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did