[FIXED] Build: failure with mingw #828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit goes to @mtmk with the proposed fix and verification that it works on mingw. I have verified that the change still works when building on my Windows VM, so I don't expect windows users to have any issue with that. Resolves #827 Signed-off-by: Ivan Kozlovic <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 68.71% 70.47% +1.76%
==========================================
Files 39 47 +8
Lines 15207 15367 +160
Branches 3143 3149 +6
==========================================
+ Hits 10449 10830 +381
+ Misses 1700 1501 -199
+ Partials 3058 3036 -22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit goes to @mtmk with the proposed fix and verification that it works on mingw.
I have verified that the change still works when building on my Windows VM, so I don't expect windows users to have any issue with that.
Resolves #827
Signed-off-by: Ivan Kozlovic [email protected]