Always snapshot stream when at compaction minimum #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <[email protected]>
MauriceVanVeen
force-pushed
the
maurice/stream-always-snapshot-at-min-size
branch
from
ffe8f1c to
eb35f8e
Compare
|
|
||
| // Don't allow the upper layer to install snapshots until we have | ||
| // fully recovered from disk. | ||
| isRecovering := true | ||
|
|
||
| doSnapshot := func() { | ||
| if mset == nil || isRecovering || isRestore || time.Since(lastSnapTime) < minSnapDelta { | ||
| if mset == nil || isRecovering || isRestore { |
There was a problem hiding this comment.
This was here to not snaphot faster then every 10s, not to snapshot every 10s..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason doing a stream snapshot at an interval of 10s (as designed) degrades performance. Removing the interval and always snapshotting when hitting compaction minimum improves performance.
Signed-off-by: Maurice van Veen [email protected]