Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDEV-106: Feature/delivery options - DO NOT MERGE #1710

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

Firdaussi
Copy link
Collaborator

Delivery Option Availability Conditions.docx
https://national-archives.atlassian.net/issues/EDEV-106

About these changes

Delivery Options are the options visible to the end user for viewing a document. They vary depending on the status of the document and the role of the user. The user has no control over the DO's.

How to check these changes

The best way to test these changes is to look at the details page for any given record. The delivery options appear in a bright yellow panel near the bottom. There are over 30 variations on the messages that can be portrayed and not all information is yet available to Etna, so some of the DO's have Jira ticket placeholder numbers for further work to be done at some point in the future.

Also, if there is an issue with the remote API, you will get a message saying that the Delivery Options are currently unavailable.

To access the remote API you will either need to be on site or using OpenVPN (see attached document). The API is only available during office hours.
OpenVPN setup.docx

css styling is another thing that needs doing and will be done under EDEV-119

Before assigning to reviewer, please make sure you have

  • [Y] Checked things thoroughly before handing over to reviewer
  • [Y] Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • [Y] Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • [Y] Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@Firdaussi Firdaussi requested a review from jamesbiggs August 22, 2024 12:17
@Firdaussi
Copy link
Collaborator Author

I will sort out the linting when I return from holiday (2nd September)

@Firdaussi Firdaussi closed this Sep 5, 2024
@Firdaussi Firdaussi reopened this Sep 5, 2024
@ahosgood ahosgood marked this pull request as draft December 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant