Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORE: YouTube Block #1674

Merged
merged 3 commits into from
Jul 11, 2024
Merged

CHORE: YouTube Block #1674

merged 3 commits into from
Jul 11, 2024

Conversation

jamesbiggs
Copy link
Collaborator

About these changes

Adds a YouTube block that allows editors to add YouTube videos to a GeneralPage

In the CMS:
image

In the API:
image

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs merged commit f94be2c into develop Jul 11, 2024
8 checks passed
@jamesbiggs jamesbiggs deleted the feature/YT-video-block branch July 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahosgood ahosgood ahosgood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbiggs @ahosgood