Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDEV-20: Catch model deletions in CI/CD #1530

Merged
merged 15 commits into from
Mar 20, 2024
Merged

EDEV-20: Catch model deletions in CI/CD #1530

merged 15 commits into from
Mar 20, 2024

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented Feb 22, 2024 •
edited
Loading

Ticket URL: EDEV-20

About these changes

Adds a CI check to capture any migrations that might hurt the database via an AlterField or DeleteModel.

How to check these changes

Where possible, provide guidance to help your reviewer

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs marked this pull request as ready for review February 22, 2024 17:23
@jamesbiggs jamesbiggs force-pushed the feature/EDEV-20-model-deletions-alterations-action branch from 8c289d2 to 1d06db6 Compare February 22, 2024 17:31
@jamesbiggs jamesbiggs force-pushed the feature/EDEV-20-model-deletions-alterations-action branch from 2d9add8 to 3f8b04b Compare February 26, 2024 11:31
@jamesbiggs jamesbiggs requested a review from ahosgood February 27, 2024 08:56
@jamesbiggs jamesbiggs requested a review from ahosgood February 28, 2024 10:48
ahosgood
ahosgood approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ahosgood ahosgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a go 👍🏼

@TNA-Allan TNA-Allan self-requested a review February 28, 2024 14:26
TNA-Allan
TNA-Allan reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@TNA-Allan TNA-Allan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be some guidance mentions about this change on the impacted activities in our project documentation?

@jamesbiggs jamesbiggs requested a review from TNA-Allan March 20, 2024 09:26
TNA-Allan
TNA-Allan approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@TNA-Allan TNA-Allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice one @jamesbiggs

@jamesbiggs jamesbiggs merged commit 5e0ed3a into develop Mar 20, 2024
7 checks passed
@jamesbiggs jamesbiggs deleted the feature/EDEV-20-model-deletions-alterations-action branch March 20, 2024 11:08
janehughes pushed a commit that referenced this pull request Mar 21, 2024
Merge branch 'experiment/image-viewer' into feature/record-viewer-int…
d820629 
…ernal-review-updates

* experiment/image-viewer:
  EDEV-91: Move from `bleach` to `nh3` (#1574)
  EDEV-85: local dev run updates (#1557)
  [DOR-66] Use correct type signature for prepare_filter_aggregations (#1572)
  EDEV-52: Media block images (and wider StreamField images) (#1561)
  EDEV-20: Catch model deletions in CI/CD (#1530)
janehughes pushed a commit that referenced this pull request Mar 21, 2024
Merge branch 'experiment/image-viewer' into fix/record-page-return-to…
8e21917 
…-search

* experiment/image-viewer:
  EDEV-91: Move from `bleach` to `nh3` (#1574)
  EDEV-85: local dev run updates (#1557)
  [DOR-66] Use correct type signature for prepare_filter_aggregations (#1572)
  EDEV-52: Media block images (and wider StreamField images) (#1561)
  EDEV-20: Catch model deletions in CI/CD (#1530)
  Add a missing migration
  Add merge migration
  Release 24.03.19.29
TNA-Allan added a commit to nationalarchives/ds-ohos-wagtail that referenced this pull request Apr 10, 2024
@TNA-Allan @jamesbiggs
@ahosgood @tm-kn @alpha-machine-user @JohnHeeryTNA @github-actions
CHORE: sync ohos etna (#64)
4a66bef 
* EDEV-87: Fix "Download XLSX" and "CSV" dropdown (nationalarchives#1553)

* EDEV-32: Article Pages API response (nationalarchives#1534)

Co-authored-by: Andrew Hosgood <[email protected]>

* Introduce APIRichTextBlock (nationalarchives#1504)

Co-authored-by: jamesbiggs <[email protected]>
Co-authored-by: James Biggs <[email protected]>

* EDEV-89: Fix media chooser (nationalarchives#1559)

* Update TNA Frontend (nationalarchives#1466)

* Change topic and time period images from 900x400 to 600x400

* CHORE:lint amends

* CHORE-sync:Added temporary deployment file

* Added `max_length` to `session_id` and `venue_type` (nationalarchives#1562)

* Update 0004_eventsession_session_id.py to include max_length here

* Update 0009_alter_eventpage_venue_type_and_more.py (nationalarchives#1563)

* Restore OHOS version of the template

* Make strtobool() return a boolean value, not an integer (0, 1) (nationalarchives#1565)

* Release 24.03.19.29

* restoring font-awesome icons

* EDEV-20: Catch model deletions in CI/CD (nationalarchives#1530)

* EDEV-52: Media block images (and wider StreamField images) (nationalarchives#1561)

* styling updates

* Formatting fix

* [DOR-66] Use correct type signature for prepare_filter_aggregations (nationalarchives#1572)

* EDEV-85: local dev run updates (nationalarchives#1557)

* EDEV-91: Move from `bleach` to `nh3` (nationalarchives#1574)

* EDEV-90:refactor results delivery options (nationalarchives#1567)

Co-authored-by: JohnHeeryTNA <[email protected]>

* EDEV-53: Media block transcript (nationalarchives#1560)

Co-authored-by: Andrew Hosgood <[email protected]>

* Fix header styles

* Increase space between header items

* Fix header menu styling on mobile

* Restrict image sizes in record revealed articles (nationalarchives#1580)

* Adjust hero image rendition size

* Hidding search results icon

* EDEV-95:Remove call to mark_safe (nationalarchives#1582)

* EDEV-35: `ContentImageBlock` API rendition (nationalarchives#1587)

* Update hero image sizes

* EDEV-93: Image Block transcript + translations (nationalarchives#1592)

* EDEV-88: Content warning (nationalarchives#1593)

* EDEV-38: verbose_public_name (nationalarchives#1594)

* Add margin above footer to space out missing feedback block (nationalarchives#1596)

* Version 24.04.03.30 (nationalarchives#1597)

Co-authored-by: GitHub Action <[email protected]>

* Version 24.04.03.31 (nationalarchives#1601)

Co-authored-by: GitHub Action <[email protected]>

* Set permissions on pulling media from production

* Remove untagged Docker images

* EDEV-99: Article tags (nationalarchives#1599)

* EDEV-102: Increase Platform.sh DB size (nationalarchives#1603)

* SYNC:Updates post sync from Etna

* SYNC:update to allow migrations

* SYNC:Remove temporary ci before merging

---------

Co-authored-by: James Biggs <[email protected]>
Co-authored-by: Andrew Hosgood <[email protected]>
Co-authored-by: jamesbiggs <[email protected]>
Co-authored-by: Tomasz Knapik <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: JohnHeeryTNA <[email protected]>
Co-authored-by: JohnHeeryTNA <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahosgood ahosgood ahosgood approved these changes

@TNA-Allan TNA-Allan TNA-Allan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesbiggs @ahosgood @TNA-Allan