Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for Clover & Universal Viewer #1501

Closed
wants to merge 34 commits into from
Closed

POC for Clover & Universal Viewer #1501

wants to merge 34 commits into from

Conversation

janehughes
Copy link
Contributor

@janehughes janehughes commented Jan 4, 2024

About these changes

Adds Clover viewer and Universal Viewer to new image viewer page type, for some initial testing of the two options side by side.

How to check these changes

Where possible, provide guidance to help your reviewer

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

TNA-Allan and others added 30 commits December 20, 2023 11:41
* feature/image-viewer:
  Push to feature/image-viewer env
  Replace strtobool
  Formatting
  Replace strtobool
  Move to Python 3.12
  FIX:Fix test compatible with python 3.12 (#1500)
  Accept Python 3.12
  DF-853 Sort by changes (#1498)
  CHORE:update search, record details templates to accommodate specific bucket details (#1497)

# Conflicts:
#	poetry.lock
* iiif-shim:
  Add help text to image viewer page
* viewer-poc:
  add tify example with some styling and lint existing code
  add mirador example
  Add help text to image viewer page

# Conflicts:
#	templates/images/image_viewer_page.html
* viewer-poc:
  create new tify npm scripts
* feature/mirador:
  Format JS, ignore mirador.min.js
  Add Mirador to image viewers comparison page
  update uv manifest url
  update iiif reference
  update manifest url for full iiif testing
@janehughes
Copy link
Contributor Author

Closing this now as it has been superseded by the work in #1526 (moving forwards with UV)

@janehughes janehughes closed this Mar 28, 2024
@ahosgood ahosgood deleted the viewer-poc branch July 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants