Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:Fix test compatible with python 3.12 #1500

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

TNA-Allan
Copy link
Collaborator

@TNA-Allan TNA-Allan commented Jan 3, 2024

Ticket URL: NA

About these changes

  • issue running tests says
ERROR: test_no_links (etna.ciim.tests.test_utils.TestResolveLinks.test_no_links)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/app/etna/ciim/tests/test_utils.py", line 127, in test_no_links
    self.assertEquals("<span/>", stripped_markup)
    ^^^^^^^^^^^^^^^^^
AttributeError: 'TestResolveLinks' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

FAILED (errors=38, skipped=37)

How to check these changes

Run test locally should not throw failures

----------------------------------------------------------------------
Ran 476 tests in 18.196s

OK (skipped=37)

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@TNA-Allan TNA-Allan marked this pull request as ready for review January 3, 2024 11:34
@TNA-Allan TNA-Allan changed the title CHORE:Fix test compatible with python 3.12 FIX:Fix test compatible with python 3.12 Jan 3, 2024
@TNA-Allan TNA-Allan merged commit 301edf9 into develop Jan 3, 2024
7 checks passed
@TNA-Allan TNA-Allan deleted the fix/tests-compatible-with-python-3-12 branch January 3, 2024 12:01
Copy link
Collaborator

@Firdaussi Firdaussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks good. Worked fine on my build.

janehughes pushed a commit that referenced this pull request Jan 4, 2024
* feature/image-viewer:
  Push to feature/image-viewer env
  Replace strtobool
  Formatting
  Replace strtobool
  Move to Python 3.12
  FIX:Fix test compatible with python 3.12 (#1500)
  Accept Python 3.12
  DF-853 Sort by changes (#1498)
  CHORE:update search, record details templates to accommodate specific bucket details (#1497)

# Conflicts:
#	poetry.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants