Jira link builder now correctly handles absent NCNs

nationalarchives · Dec 19, 2024 · 8a5eeda · 8a5eeda
1 parent 37a2e9f
commit 8a5eeda
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/judgments/utils/link_generators.py b/judgments/utils/link_generators.py
@@ -10,6 +10,7 @@
 
 if TYPE_CHECKING:
     from caselawclient.models.documents import Document
+    from caselawclient.models.identifiers import Identifier
     from django.http import HttpRequest
 
 
@@ -85,7 +86,7 @@ def build_jira_create_link(document: Document, request: HttpRequest) -> str:
         reverse("full-text-html", kwargs={"document_uri": document.uri}),
     )
 
-    preferred_ncn = document.identifiers.preferred(type=NeutralCitationNumber)
+    preferred_ncn: Identifier | None = document.identifiers.preferred(type=NeutralCitationNumber)
 
     description_string = "{editor_html_url}".format(
         editor_html_url="""{html_url}