Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing networkx install for analyst build #154

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

marinagmoreira
Copy link
Member

@marinagmoreira marinagmoreira commented Feb 28, 2024

@marinagmoreira marinagmoreira linked an issue Feb 28, 2024 that may be closed by this pull request
@marinagmoreira marinagmoreira requested a review from trey0 February 28, 2024 18:03
Copy link
Contributor

@trey0 trey0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just missed one section to uncomment. Glad this was so easy ;)

@@ -57,13 +57,10 @@ jobs:
--build-arg REMOTE=ghcr.io/nasa
-t ghcr.io/${{ github.repository_owner }}/isaac:msgs-ubuntu20.04

# Temp disabling the analyst build because it has a version conflict issue. Re-enable once
# #136 is fixed.
# *** Remember to uncomment the push below, as well!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this! Refers to:

# Re-enable once #136 is fixed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@marinagmoreira marinagmoreira merged commit 1897f0c into nasa:develop Feb 28, 2024
4 checks passed
@marinagmoreira marinagmoreira deleted the fix_networkx_install branch February 28, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix version conflict in Python dependencies of analyst image
2 participants