Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make ci_pr.yml use less space #135

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

trey0
Copy link
Contributor

@trey0 trey0 commented Feb 8, 2024

See bug report / discussion here #132 (comment)

The concept is to make ci_pr.yml work more like ci_push.yml (but without the push) since the latter is building mostly the same stuff in a different way and is still working.

@trey0
Copy link
Contributor Author

trey0 commented Feb 8, 2024

Note: Building the analyst image on develop is currently broken due to a new version conflict issue in the Python dependencies. See example here https://github.com/nasa/isaac/actions/runs/7835253902/job/21380266683

Copy link
Member

@bcoltin bcoltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marinagmoreira I spoke with trey and am going to go ahead and merge this since it's probably better to have something working and fix it later if there are issues, but please do take a look and make sure this makes sense to you since you know the most about our CI

@bcoltin bcoltin merged commit a1fe08c into nasa:develop Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants