Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make ci_pr.yml use less space #134

Closed
wants to merge 29 commits into from
Closed

Conversation

trey0
Copy link
Contributor

@trey0 trey0 commented Feb 8, 2024

See bug report / discussion here #132 (comment)

The concept is to make ci_pr.yml work more like ci_push.yml (but without the push) since the latter is building mostly the same stuff in a different way and is still working.

marinagmoreira and others added 29 commits May 18, 2023 11:08
* find point from image coord in point cloud and mesh

* fixing merge

* fix merge

* adding auto height and width determination because the config doesn't have it

* fixing CI, adding flags instead of hardcoded topics

* adding documentation; tweak interface

* fixing some of the comments from PR

* adding more documentation

* fix xenial build
* infrastructure work on docker processes

* making ci pr use the build script

* analyst notebook now depends on entire isaac for python packages

* fixing astrobee path

* sintax + analyst only in ubuntu 20
* small fixes for running docker images

* starting work on pano coord estimation

* merging CameraModel and CameraProjection classes

* start query c++ tool

* adding topics in isaac names instead of hardcoded

* removing wifi plugin temporarily to allow multiple robots to be spawned

* changes to analyst docker build/run

* simplifying launch file

* bag read script changes

* updating jupyter notebooks files

* fix lint
* making spawn changes and adding double handed cargo

* adding devcontainer file

* clean up analyst query demo; save and upload database scripts

* making multiple bag loading collection creation not clash

* adding multiple devcontainer profiles; load database progress

* adding main for running standalone

* small changes from database upload

* fix lint
* anomaly/gmm: Add GMM-based change detection algorithm

Signed-off-by: Jamie Santos <[email protected]>

* caching: add directory for saving files

Signed-off-by: Jamie Santos <[email protected]>

* emd: update the PuLP solver to glpk for compatibility with ARM architecture

Signed-off-by: Jamie Santos <[email protected]>

* gmm_change_detection: remove redundant packages

Signed-off-by: Jamie Santos <[email protected]>

* caching: streamline file handling

Signed-off-by: Jamie Santos <[email protected]>

* caching: add predictions for points for complete model

With this commit, the caching is now in a functional state.

Signed-off-by: Jamie Santos <[email protected]>

* Remove extraneous code from previous clustering algorithm

Signed-off-by: Jamie Santos <[email protected]>

* gmm: remove extra model fitting

Signed-off-by: Jamie Santos <[email protected]>

* caching: remove files for GMM cache debugging

Signed-off-by: Jamie Santos <[email protected]>

* passing python code through linters

* Add object disappearance detection

Signed-off-by: Jamie Santos <[email protected]>

* wip: preprocess: only save images once point cloud is obtained

Signed-off-by: Jamie Santos <[email protected]>

* artificial_data: randomly generate point clouds with specified changes

- Can now get random point clouds with specified start, appearances, and
disappearances

Signed-off-by: Jamie Santos <[email protected]>

* organize scripts into package structure

* adding some headers and converting file from dos to unix

* remote duplicate commented code that is in artificial_data.py

* running on ubuntu 20 the example fake data

* first pass at refactoring the code to simplify it

* removing test data since it can be generated easily

* starting jupyter notebook with basic features and no plot customization

* tested all modes

* merge ground truth with pre-process data

---------

Signed-off-by: Jamie Santos <[email protected]>
Co-authored-by: Jamie Santos <[email protected]>
* Update `INSTALL.md`

Fixes minor typos and improves parallelism with astrobee docs.

* Fix Torch install path check

Path expansion was not working as expected

* Install `devscripts` for debian build on 20.04
* making spawn changes and adding double handed cargo

* fixing bug where cam_name wasn't initialized

* adding things from review and some bugfixes
* making spawn changes and adding double handed cargo

* adding configurable transform + better instructions with demo
* Plansys2 on Astrobee Noetic (nasa#107)

* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Add files via upload

Adding planning domain, problem, and xml of the atomic actions of the robotic agents

* added  files to the correct directory

* adding soft constraints problem files

* Attempt at a complete MVP domain model

* Oops, remove redundant effect

* Simplified collision checking predicate

* In a working state

* Add sample_output_plan.txt

* Oops, remove obsolete commented-out code

* Fixed stereo survey part of the model based on analysis of old stereo surveys by Marina - unfortunately causes additional planner flakiness

* Update sample_output_plan.txt to reflect latest domain/problem

* Now generate PDDL problem from higher-level problem specification

* Tune panorama estimated duration

* Add plan_interpreter.py. Minor cleanup in problem_generator.py

* Simplify dynamic config just a bit

* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Remove `survey_bridge` capability will be added to `astrobee`

* Add traclabs plansys2 backport via submodule, thanks @ana-GT

* Move sub-modules to `survey_manager` path

* Upgrade behaviortree to V4

NOTE: If already installed, remove V3 before installing V4

* Cleanup unused, misplaced sub-modules, again.

* Remove `survey_manager` package and organize `survey_planner`

* Deprecate Ubuntu-16.04 (xenial) builds of Isaac to support Plansys2

- Remove Ubuntu-16.04 (xenial) CI builds
- Update dockerfile ubuntu version defaults to Ubuntu-20.04 (focal)
- Update apk build environment to Ubuntu-20.04 (focal)

* Fix python formatting

* Update to forks of traclabs backports

* Add readline development files to setup for plansys2 terminal interface

If you have already built your VM, run `sudo apt install libreadline-dev`

* Removed outdated PDDL files per @trey0

nasa#107 (comment)

* Revert CI upgrades for APK builds

---------

Co-authored-by: Abiola Akanni <[email protected]>
Co-authored-by: Trey Smith <[email protected]>

* Update ci_pr.yml

make survey manager PR's run CI

* problem_generator.py: Simplified config, and runs with default args again

* Removed run number argument from planner actions

* Add support for PlanSys2 terminal output; remove num-orders from config

* Refactor problem_generator.py to more cleanly support two output formats

* plan_interpreter.py works with default arguments again

* Update .isort.cfg using scripts/git/configure_isort_paths.sh

* jem_survey_dynamic.yaml: Remove unused run parameter.

* Fix legacy isort styling error in unrelated file so lint passes

* Added let-other-robot-reach constraint so we can solve the full problem with POPF/OPTIC

* Fix pylint and mypy complaints

* Make predicates on one line.

* update submodules

* update submodule

---------

Co-authored-by: Bckempa <[email protected]>
Co-authored-by: Abiola Akanni <[email protected]>
Co-authored-by: Trey Smith <[email protected]>
Co-authored-by: Brian Coltin <[email protected]>
* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Add files via upload

Adding planning domain, problem, and xml of the atomic actions of the robotic agents

* added  files to the correct directory

* adding soft constraints problem files

* Attempt at a complete MVP domain model

* Oops, remove redundant effect

* Simplified collision checking predicate

* In a working state

* Add sample_output_plan.txt

* Oops, remove obsolete commented-out code

* Fixed stereo survey part of the model based on analysis of old stereo surveys by Marina - unfortunately causes additional planner flakiness

* Update sample_output_plan.txt to reflect latest domain/problem

* Now generate PDDL problem from higher-level problem specification

* Tune panorama estimated duration

* Add plan_interpreter.py. Minor cleanup in problem_generator.py

* Simplify dynamic config just a bit

* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Remove `survey_bridge` capability will be added to `astrobee`

* Add traclabs plansys2 backport via submodule, thanks @ana-GT

* Move sub-modules to `survey_manager` path

* Upgrade behaviortree to V4

NOTE: If already installed, remove V3 before installing V4

* Cleanup unused, misplaced sub-modules, again.

* Remove `survey_manager` package and organize `survey_planner`

* Deprecate Ubuntu-16.04 (xenial) builds of Isaac to support Plansys2

- Remove Ubuntu-16.04 (xenial) CI builds
- Update dockerfile ubuntu version defaults to Ubuntu-20.04 (focal)
- Update apk build environment to Ubuntu-20.04 (focal)

* Fix python formatting

* Update to forks of traclabs backports

* Add readline development files to setup for plansys2 terminal interface

If you have already built your VM, run `sudo apt install libreadline-dev`

* Removed outdated PDDL files per @trey0

nasa#107 (comment)

* Revert CI upgrades for APK builds

* Plansys2 on Astrobee Noetic (nasa#107)

* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Add files via upload

Adding planning domain, problem, and xml of the atomic actions of the robotic agents

* added  files to the correct directory

* adding soft constraints problem files

* Attempt at a complete MVP domain model

* Oops, remove redundant effect

* Simplified collision checking predicate

* In a working state

* Add sample_output_plan.txt

* Oops, remove obsolete commented-out code

* Fixed stereo survey part of the model based on analysis of old stereo surveys by Marina - unfortunately causes additional planner flakiness

* Update sample_output_plan.txt to reflect latest domain/problem

* Now generate PDDL problem from higher-level problem specification

* Tune panorama estimated duration

* Add plan_interpreter.py. Minor cleanup in problem_generator.py

* Simplify dynamic config just a bit

* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Remove `survey_bridge` capability will be added to `astrobee`

* Add traclabs plansys2 backport via submodule, thanks @ana-GT

* Move sub-modules to `survey_manager` path

* Upgrade behaviortree to V4

NOTE: If already installed, remove V3 before installing V4

* Cleanup unused, misplaced sub-modules, again.

* Remove `survey_manager` package and organize `survey_planner`

* Deprecate Ubuntu-16.04 (xenial) builds of Isaac to support Plansys2

- Remove Ubuntu-16.04 (xenial) CI builds
- Update dockerfile ubuntu version defaults to Ubuntu-20.04 (focal)
- Update apk build environment to Ubuntu-20.04 (focal)

* Fix python formatting

* Update to forks of traclabs backports

* Add readline development files to setup for plansys2 terminal interface

If you have already built your VM, run `sudo apt install libreadline-dev`

* Removed outdated PDDL files per @trey0

nasa#107 (comment)

* Revert CI upgrades for APK builds

---------

Co-authored-by: Abiola Akanni <[email protected]>
Co-authored-by: Trey Smith <[email protected]>

* Update ci_pr.yml

make survey manager PR's run CI

* problem_generator.py: Simplified config, and runs with default args again

* Removed run number argument from planner actions

* Add support for PlanSys2 terminal output; remove num-orders from config

* Refactor problem_generator.py to more cleanly support two output formats

* plan_interpreter.py works with default arguments again

* Update .isort.cfg using scripts/git/configure_isort_paths.sh

* jem_survey_dynamic.yaml: Remove unused run parameter.

* Fix legacy isort styling error in unrelated file so lint passes

* Remove newlines in PDDL domain predicates to work around [1]

[1] PlanSys2/ros2_planning_system#286

* Setup planner stack for action tests

* Move submodules to avoid nested catkin packages

* Added let-other-robot-reach constraint so we can solve the full problem with POPF/OPTIC

* Fix pylint and mypy complaints

* Add `popf` package and remove vendored solver in favor of built binary

* Update plansys2 backport to fix domain validation and parameters

* Make predicates on one line.

* Update vendored libraries for cross compilation

* making submodules their own folder for organization

* updating submodule + fix bug in cmake

* only check isort files that were modified

* src dir doesn't exist anymore and usually not in include

* fix gitmodules link

* fixing PR CI

---------

Co-authored-by: Abiola Akanni <[email protected]>
Co-authored-by: Trey Smith <[email protected]>
Co-authored-by: Marina Moreira <[email protected]>
Co-authored-by: Brian Coltin <[email protected]>
Co-authored-by: Marina Moreira <[email protected]>
* making spawn changes and adding double handed cargo

* adding a proof of concept example of the executor

* running through isort

* committing before changing things around

* sockets working

* fix lint

* adding example action node

* update to scripts with new requirements

* thread join safeguard

* running isort

* Plansys2 on Astrobee Noetic (nasa#107)

* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Add files via upload

Adding planning domain, problem, and xml of the atomic actions of the robotic agents

* added  files to the correct directory

* adding soft constraints problem files

* Attempt at a complete MVP domain model

* Oops, remove redundant effect

* Simplified collision checking predicate

* In a working state

* Add sample_output_plan.txt

* Oops, remove obsolete commented-out code

* Fixed stereo survey part of the model based on analysis of old stereo surveys by Marina - unfortunately causes additional planner flakiness

* Update sample_output_plan.txt to reflect latest domain/problem

* Now generate PDDL problem from higher-level problem specification

* Tune panorama estimated duration

* Add plan_interpreter.py. Minor cleanup in problem_generator.py

* Simplify dynamic config just a bit

* Add `survey_manager` subdirectory without layout for survey nodes

Includes placeholder directories with hyperlinked `readme.md` files in
the documentation hierarchy for the manger, planner, and bridge.

Per discussion with @marinagmoreira `survey_manager` lives under
`astrobee` to signify the code is intended for cross-compilation.

* Improve linking to survey manager docs

* Remove `survey_bridge` capability will be added to `astrobee`

* Add traclabs plansys2 backport via submodule, thanks @ana-GT

* Move sub-modules to `survey_manager` path

* Upgrade behaviortree to V4

NOTE: If already installed, remove V3 before installing V4

* Cleanup unused, misplaced sub-modules, again.

* Remove `survey_manager` package and organize `survey_planner`

* Deprecate Ubuntu-16.04 (xenial) builds of Isaac to support Plansys2

- Remove Ubuntu-16.04 (xenial) CI builds
- Update dockerfile ubuntu version defaults to Ubuntu-20.04 (focal)
- Update apk build environment to Ubuntu-20.04 (focal)

* Fix python formatting

* Update to forks of traclabs backports

* Add readline development files to setup for plansys2 terminal interface

If you have already built your VM, run `sudo apt install libreadline-dev`

* Removed outdated PDDL files per @trey0

nasa#107 (comment)

* Revert CI upgrades for APK builds

---------

Co-authored-by: Abiola Akanni <[email protected]>
Co-authored-by: Trey Smith <[email protected]>

* bug fixes

* fixes

* Update ci_pr.yml

make survey manager PR's run CI

* moving executor to different package hierarchy

* consolidating packages; action compiling

* tested action

* submodule update

* move scripts into package

* changing static config to be more general

* fixing config name + install data folder

* restoring comms to readline

* getting details sorted

* making output more readable

* installing script to be found in robot install

* adding move action starting correct process

* adding parameters for easy testing

* fixes on command astrobee

* add remaining actions + documentation

* running isort

* Use exec and waitpid instead of reading output.

* Change all action nodes to use the same class.

* install all nodes

* adding remote option with no parameter adjusting, we'll do panoramas using geometry

* reset progress after one action

* adding inspection lib; fixing output

* fixing robot install

* tested all 5 actions in the granite table

* remote plansys2 submodules from doxygen

* splitting documentation

* addressing tons of comments on PR, lab tested

* more PR reviews

* more PR reviews

* more PR reviews

---------

Co-authored-by: Bckempa <[email protected]>
Co-authored-by: Abiola Akanni <[email protected]>
Co-authored-by: Trey Smith <[email protected]>
Co-authored-by: Brian Coltin <[email protected]>
Add OPTIC and trey planners and bug fix plansys2
@trey0 trey0 requested a review from bcoltin February 8, 2024 20:19
@trey0 trey0 requested a review from marinagmoreira February 8, 2024 20:19
@trey0
Copy link
Contributor Author

trey0 commented Feb 8, 2024

Oops PR should have been against develop.

@trey0 trey0 closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants