Fix cam name var #105
Merged
Fix cam name var #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trey0
approved these changes
Nov 15, 2023
| @@ -69,7 +69,7 @@ class CameraView : public camera::CameraModel { | |||
| // f: far clip, maximum camera distance (m) | |||
| // n: near clip, minimum camera distance (m) | |||
| // cam_transform: transform from body->camera, useful for offline applications where tf is not available | |||
| CameraView(const camera::CameraParameters & params, const float f = 2.0, const float n = 0.19, | |||
| CameraView(const std::string, const camera::CameraParameters & params, const float f = 2.0, const float n = 0.19, | |||
There was a problem hiding this comment.
Suggested change
| CameraView(const std::string, const camera::CameraParameters & params, const float f = 2.0, const float n = 0.19, | |
| CameraView(const std::string& cam_name, const camera::CameraParameters & params, const float f = 2.0, const float n = 0.19, |
(Usually better to pass std::string as ref to avoid unnecessary extra copy, also style consistency of including the argument name.)
| @@ -34,10 +34,9 @@ namespace inspection { | |||
| the camera frame and the other way around. It automatically reads the camera parameters | |||
| from the config files based on the camera name, such that no setup is necessary. | |||
| */ | |||
| CameraView::CameraView(const camera::CameraParameters & params, const float f, const float n, | |||
| CameraView::CameraView(const std::string cam_name, const camera::CameraParameters& params, const float f, const float n, | |||
There was a problem hiding this comment.
Suggested change
| CameraView::CameraView(const std::string cam_name, const camera::CameraParameters& params, const float f, const float n, | |
| CameraView::CameraView(const std::string& cam_name, const camera::CameraParameters& params, const float f, const float n, |
| @@ -215,7 +215,7 @@ int main(int argc, char** argv) { | |||
| new geometry_msgs::Transform(msg_conversions::eigen_transform_to_ros_transform(transform_body_to_cam))); | |||
|
|
|||
| camera::CameraParameters cam_params(&config, camera_name.c_str()); | |||
| inspection::CameraView camera(cam_params, 2.0, 0.19, msg_pointer); | |||
| inspection::CameraView camera(camera_name.c_str(), cam_params, 2.0, 0.19, msg_pointer); | |||
There was a problem hiding this comment.
Suggested change
| inspection::CameraView camera(camera_name.c_str(), cam_params, 2.0, 0.19, msg_pointer); | |
| inspection::CameraView camera(camera_name, cam_params, 2.0, 0.19, msg_pointer); |
(Converting to char * shouldn't be needed here unless I missed something.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cam name wasn't being initialized after the changes that were made to integrate the camera class into the camera_model