Update install instructions and scripts #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes minor typos and improves parallelism with astrobee docs.
Path expansion was not working as expected
| The configure script modifies your ``.bashrc`` to source ``setup.bash`` for | ||
| the current ROS distribution and to set CMAKE_PREFIX_PATH. It is suggested | ||
| to examine it and see if all changes were made correctly. | ||
| If you run a Zsh session, then |
There was a problem hiding this comment.
I don't use Zsh sessions so this might not apply, but we do have some scripts that add paths to the .bashrc since that is what is it used by default in ubuntu (I don't even have a ~/.zshrc file). Encouraging people to use Zsh might have unintended consequences..
There was a problem hiding this comment.
I added it for parity with the Astrobee docs which support both. My concern was anyone using Astrobee with zsh getting strange behavior if they don't notice the change when moving over to ISAAC.
We can strip them all out if you'd rather; makes no difference to me.
marinagmoreira
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves setup documentation and scripting based on experience with a fresh 20.04 install.
INSTALL.mdand improve parallelism with Astrobee install docsdevscriptspackage when building Debians on 20.04