-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4267: Implementing notebook generation on granule list view #1840
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
==========================================
+ Coverage 93.52% 93.54% +0.02%
==========================================
Files 774 777 +3
Lines 18709 18787 +78
Branches 4787 4822 +35
==========================================
+ Hits 17497 17575 +78
+ Misses 1164 1131 -33
- Partials 48 81 +33 ☔ View full report in Codecov by Sentry. |
static/src/js/components/GranuleResults/GranuleResultsDownloadNotebookButton.jsx
Show resolved
Hide resolved
static/src/js/components/GranuleResults/GranuleResultsDownloadNotebookButton.jsx
Outdated
Show resolved
Hide resolved
.../src/js/containers/GranuleResultsBodyContainer/__tests__/GranuleResultsBodyContainer.test.js
Outdated
Show resolved
Hide resolved
.../src/js/containers/GranuleResultsBodyContainer/__tests__/GranuleResultsBodyContainer.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix the tests and we'll be good to go
Overview
What is the feature?
Adds the ability to download a sample Jupiter notebook from a granule search result, if the collection is properly configured.
What is the Solution?
What areas of the application does this impact?
Testing
Reproduction steps
Generate a notebook without a bounding box
/search/granules?p=C1238621141-POCLOUD
with theee
param set touat
Generate a notebook with a bounding box
/search/granules?p=C1238621141-POCLOUD
with theee
param set touat
Confirm the notebook download button does not exist for other collections
C1238621141-POCLOUD
Checklist