-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fault documentation #64
base: develop
Are you sure you want to change the base?
Conversation
It looks like it is generated from the csv file... can we not just save the csv file in the repo? Having code generated from Excel spreadsheets terrifies me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the table is really big, having it directly in csv would be complete gibberish (it would also lose information so a different file would need to be kept separately to keep track of it). Maybe an alternative would be json/yaml?
|
||
# Fault Config Files Generation | ||
|
||
There is a script that will generate the fault config files by parsing the FMECA spreadsheet. This script assumes the steps in the previous section were completed and the FMECA spreadsheet was saved as a csv file in the doc folder. If it was not saved in the doc folder, please set the FMECA_CSV_PATH environment variable to folder were it was saved. Then run the following line: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I save as csv, it only saves the first page, is that ok? (skips the not monitored faults)
We have decided that the FMECA should be converted to a json file much like our command schema. The tools that process the FMECA spreadsheet will also need to be converted. |
Katie would still like to do this, and may have time early in 2024. If not we should close this. |
Moved the FMECA spreadsheet from freeflyer_docs to the doc folder. Also added documentation on how to add faults and modified the generate faults config script to account for the FMECA being moved.