This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Add message linking to copier template and exit before prompts #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willingc
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Sweet! I would consider adding the repo URL at the start of the message too. Thanks @DragaDoncila ☀️
| print("python -m pip install npe2") | ||
| print("copier copy --trust https://github.com/napari/napari-plugin-template new-plugin-name") | ||
| print() | ||
| print("For more information, refer to the template README:") |
There was a problem hiding this comment.
Sweet!
This works well locally. It's fine to merge as is.
I think that it makes sense to give the location of the new template's repo before the how to use the new template.
It won't hurt to have the new repo listed twice. Once at the beginning and once at the end.
jni
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks @DragaDoncila!
@willingc in the interest of closing this loop and since this repo is headed for the dustbin of history, I'm going to merge as is and archive the repo. Thank you for trying it out!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191.
This PR adds a
pre_prompt.pyhook that advises the user about how to run the newnapari-plugin-template, links to the new template repo, and then exits before presenting any prompts.