This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Bugfix: move endif and reader-if so all widgets work if only widgets are give y
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jni
approved these changes
Feb 20, 2024
I don't know anything about how the cookiecutter is tested but I will merge this quickly and we can worry about testing elsewhere, since this will immediately improve the situation for any users. Thank you for the quick fix @psobolewskiPhD! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #172
In #168 when widgets got an update a logic error was introduced into napari.yaml. This shifts the endif and if to the proper line (after all of the widgets).
I tested locally and could reproduce the issue and this fixes it.
I wonder if we should try to extend the make and install test to try each of the plugin types individually?