Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler utils #217

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Sampler utils #217

wants to merge 15 commits into from

Conversation

astrolamb
Copy link
Contributor

I removed the additional module I added from this PR that contained @paulthebaker's sampler utility functions.

I've added these utilities to sampler.py. This has allowed me to remove all of the various draw_from_x functions, and instead create a loop that create jump proposals if a given signal type is found in PTA model, based on the signal types created by enterprise.

I also added automatic pulsar grouping for better sampling of pulsar-dependent parameters.

Tests have been updated to reflect these changes.

TO DO:
JumpProposal should probably be cleaned up

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Merging #217 (537efe1) into master (541dd1f) will increase coverage by 2.85%.
The diff coverage is 66.97%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   37.23%   40.09%   +2.85%     
==========================================
  Files          20       20              
  Lines        3969     3614     -355     
==========================================
- Hits         1478     1449      -29     
+ Misses       2491     2165     -326     
Files Coverage Δ
enterprise_extensions/hypermodel.py 50.52% <75.00%> (+2.22%) ⬆️
enterprise_extensions/sampler.py 61.65% <65.59%> (+23.64%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541dd1f...537efe1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants