Fix display bug while setting up in table #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table used to leave behind artifacts during the setup process. I think this happened because the table would grow and then shrink in height, leaving behind w/e was at the top most portion of the table. This change adds some dynamic padding to the table so it never shrinks in height, but also doesn't pre-reserve the max padding in case none of the targets cause the table to grow.
Found out that the table automatically handles the terminal not being wide enough. Looks better to not wrap any of the columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table used to leave behind artifacts during the setup process. I think this happened because the table would grow and then shrink in height, leaving behind w/e was at the top most portion of the table. This change adds some dynamic padding to the table so it never shrinks in height, but also doesn't pre-reserve the max padding in case none of the targets cause the table to grow.