perf: Benchmark nodes-base
#9355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
netroy
reviewed
May 10, 2024
n8n-assistant
bot
added
n8n team
netroy
reviewed
May 10, 2024
| @@ -14,6 +14,8 @@ | |||
| "url": "git+https://github.com/n8n-io/n8n.git" | |||
| }, | |||
| "scripts": { | |||
| "benchmark:build": "tsc -p tsconfig.benchmark.json > /dev/null; tsc-alias -p tsconfig.benchmark.json; pnpm build:metadata", | |||
There was a problem hiding this comment.
To silence type errors when transpiling test helpers. Did not fix those here to avoid a larger PR.
| @@ -373,6 +386,9 @@ export const workflowToTests = (workflowFiles: string[]) => { | |||
| ); | |||
| } | |||
| }); | |||
|
|
|||
| if (process.env.NODE_ENV === 'benchmark') workflowData.pinData = {}; | |||
There was a problem hiding this comment.
we use pinData for assertions. does this change mean that we disable those assertions when running nodes tests for benchmarking?
There was a problem hiding this comment.
Benchmarks use executeWorkflow but do not use equalityTest so they sidestep all Jest assertions.
This line specifically I added because a handful of workflows (MoveBinaryData, QuickChart) were getting caught by the pindata check right after this line, because they have their own implementation of testWorkflows.
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
Could we do a on-the-fly compilation of TS code (like ts-jest does), instead of needing yet another tsconfig?
netroy
previously approved these changes
May 10, 2024
1 flaky test on run #4925 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9355 ↗︎
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP