Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Cron Node): Add workflow test to Cron node (no-changelog) #12383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(Cron Node): Add workflow test to Cron node (no-changelog) #12383

wants to merge 1 commit into from

Conversation

dana-gill
Copy link
Contributor

@dana-gill dana-gill commented Dec 27, 2024 •
edited
Loading

Summary

Add workflow test to Cron node

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2195/improve-cron-node-testing

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill changed the title test(Cron): Add workflow test to Cron node test(Cron): Add workflow test to Cron node (no-changelog) Dec 27, 2024
@dana-gill dana-gill changed the title test(Cron): Add workflow test to Cron node (no-changelog) test(Cron Node): Add workflow test to Cron node (no-changelog) Dec 27, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 27, 2024
@dana-gill dana-gill marked this pull request as ready for review December 27, 2024 11:35
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@dana-gill dana-gill force-pushed the node-2195-cron-testing branch from 0023f67 to 01799ce Compare December 27, 2024 12:32
@dana-gill dana-gill force-pushed the node-2195-cron-testing branch from 01799ce to 95ec81f Compare December 27, 2024 12:36
netroy
netroy approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cron node was deprecated over 2 years ago in #4223.
Maybe we can create more tests for the Scheduler node instead?
But, we can also merge this.

@cypress Cypress
Copy link

cypress bot commented Dec 27, 2024

n8n    Run #8484

Run Properties:  status check passed Passed #8484  •  git commit 95ec81f088: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 dana-gill 🗃️ e2e/*
Project n8n
Branch Review node-2195-cron-testing
Run status status check passed Passed #8484
Run duration 04m 48s
Commit git commit 95ec81f088: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 dana-gill 🗃️ e2e/*
Committer Dana Lee
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 483
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dana-gill @netroy