Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Encapsulate logic to create new credential into its own method #12361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 24, 2024

Summary

prep work to be able to add a new endpoint to create manage credentials. Context in the linear ticket below

We already have tests for this endpoint here ->

describe('POST /credentials', () => {

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2998/[n8n-backend]-add-new-endpoint-to-save-managed-credentials

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Encapsulate logic to create new credential into its own method refactor(cli): Encapsulate logic to create new credential into its own method Dec 24, 2024
@RicardoE105 RicardoE105 changed the title refactor(cli): Encapsulate logic to create new credential into its own method refactor(core): Encapsulate logic to create new credential into its own method Dec 24, 2024
@RicardoE105 RicardoE105 requested a review from mutdmour December 24, 2024 15:59
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But, we should maybe take this opportunity to add tests for this code.

@RicardoE105
Copy link
Contributor Author

@netroy was not to worried because we already have a BE e2e test to cover the functionality of the endpoint, but I guess it would not hurt to add a test to service method. Will do today, thanks for having a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants