refactor(core): Fix push message type inference #12331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
netroy
reviewed
Dec 20, 2024
| @@ -156,7 +157,7 @@ export class PubSubHandler { | |||
| 'relay-execution-lifecycle-event': async ({ type, args, pushRef }) => { | |||
| if (!this.push.getBackend().hasPushRef(pushRef)) return; | |||
|
|
|||
| this.push.send(type, args, pushRef); | |||
| this.push.send({ type, data: args } as PushMessage, pushRef); | |||
There was a problem hiding this comment.
instead of casting as PushMessage here, maybe we could update the types for this event in packages/cli/src/events/maps/pub-sub.event-map.ts?
There was a problem hiding this comment.
Ended up removing all generics from push as well: 75b9e71
netroy
approved these changes
Dec 20, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 54s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
483
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
Push.sendargument so that TypeScript is able to narrow down payloads based on push types.