chore: Add more e2e Sub-Workflow Input testing #12308
Conversation
…o resourceMapperTypeConversion
…o resourceMapperTypeConversion
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
| @@ -83,6 +93,21 @@ function navigateWorkflowSelectionDropdown(index: number, expectedText: string) | |||
| .click(); | |||
| } | |||
|
|
|||
| function populateMapperFields(values: readonly string[], offset: number) { | |||
There was a problem hiding this comment.
Does it make sense to move these local functions to actions (maybe here)? I know these pages are getting out of hand (we can maybe create a new one just for RMC), so feel free to push back, but I am worried about mixing actions and utli functions to do the same thing.
There was a problem hiding this comment.
Yes, strongly agree with this needing a refactor before (maybe master) merge, I'm defining them as I'm iterating for now. I'm also not happy with the sub-functions I'm defining in the big test case.
There was a problem hiding this comment.
Yes, we have it in few other places, it's not a bad pattern to be honest it's just about consistency. But, looks like a big push to get e2e tests in order is around the corner so good to go like this
Summary
Test json mode and add WIP test for type option flags and resourceMapper fields.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2915/add-tests-for-the-feature
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)