Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add stale data warning to Resource Mapper #12305

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Dec 19, 2024

Summary

  • Implementing stale data warning + refresh fields button for resource mapper

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Dec 19, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 19, 2024
@MiloradFilipovic MiloradFilipovic marked this pull request as draft December 19, 2024 13:14
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 87.70492% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...editor-ui/src/composables/useDocumentVisibility.ts 70.58% 10 Missing ⚠️
...i/src/components/ResourceMapper/ResourceMapper.vue 90.69% 4 Missing ⚠️
...ui/src/components/ResourceMapper/MappingFields.vue 94.73% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@MiloradFilipovic MiloradFilipovic marked this pull request as ready for review December 19, 2024 15:00
Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 🙌 Happy to ship as is.

Is there a quick way of adding a red dot to the icon? It's pretty obvious in light mode but easy to miss in dark mode and the red dot == go here association seems handy here if we can get this for cheap.

packages/editor-ui/src/utils/nodeTypesUtils.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/utils/nodeSettingsUtils.test.ts Outdated Show resolved Hide resolved
@MiloradFilipovic
Copy link
Contributor Author

Really nice 🙌 Happy to ship as is.

Is there a quick way of adding a red dot to the icon? It's pretty obvious in light mode but easy to miss in dark mode and the red dot == go here association seems handy here if we can get this for cheap.

I was talking about adding warning icon with Rob and we decided to go like this but more I look at it the more I see we should add something. Let me check about the red dot. If we don't have such a pattern in the design system, I'll add an icon quickly

Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fast 🚀 Really nice!

@MiloradFilipovic MiloradFilipovic merged commit 0616a32 into feature-sub-workflow-inputs Dec 20, 2024
18 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3018-resource-mapper-stale-data-check branch December 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants