-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add stale data warning to Resource Mapper #12305
feat(editor): Add stale data warning to Resource Mapper #12305
Conversation
…per-stale-data-check
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice 🙌 Happy to ship as is.
Is there a quick way of adding a red dot to the icon? It's pretty obvious in light mode but easy to miss in dark mode and the red dot == go here
association seems handy here if we can get this for cheap.
I was talking about adding warning icon with Rob and we decided to go like this but more I look at it the more I see we should add something. Let me check about the red dot. If we don't have such a pattern in the design system, I'll add an icon quickly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So fast 🚀 Really nice!
0616a32
into
feature-sub-workflow-inputs
Summary
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)