Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Community PR Guidelines (no-changelog) #12303

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

ShireenMissi
Copy link
Contributor

Summary

This PR updates the contributing document to include rules and guidelines for community pull requests. These updates aim to provide clearer expectations and improve the process for submitting contributions. Key additions include:

  • Guidance on addressing change requests and providing feedback.
  • General requirements, such as adhering to style guides and avoiding repetitive code.
  • Specific rules for PR submissions, like size limitations and naming conventions.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2179/contributing-community-pr-guidelines

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@ShireenMissi ShireenMissi changed the title chore: Add Community PR Guidelines chore: Add Community PR Guidelines (no-changelog) Dec 19, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 19, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ShireenMissi ShireenMissi merged commit e5587ff into master Dec 20, 2024
19 checks passed
@ShireenMissi ShireenMissi deleted the node-2179-contributing-community-pr-guidelines branch December 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants