Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up some code #12287

Merged
merged 2 commits into from
Dec 30, 2024
Merged

chore: Clean up some code #12287

merged 2 commits into from
Dec 30, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Dec 18, 2024

Summary

Clean up some code

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 18, 2024
@tomi tomi force-pushed the chore-clean-up-code branch from 7ab2808 to 00e9100 Compare December 19, 2024 07:27
@tomi tomi force-pushed the chore-clean-up-code branch from 00e9100 to df878cf Compare December 19, 2024 10:35
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 20, 2024

n8n    Run #8500

Run Properties:  status check passed Passed #8500  •  git commit f1c3e22c4d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review chore-clean-up-code
Run status status check passed Passed #8500
Run duration 04m 41s
Commit git commit f1c3e22c4d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 484
View all changes introduced in this branch ↗︎

@tomi tomi requested a review from ivov December 30, 2024 12:53
@tomi
Copy link
Contributor Author

tomi commented Dec 30, 2024

@ivov merged master, could you reapprove 🙏

Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit f08db47 into master Dec 30, 2024
51 of 67 checks passed
@tomi tomi deleted the chore-clean-up-code branch December 30, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants