Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Nodes' icon color in dark mode #12279

Merged

Conversation

burivuhster
Copy link
Contributor

@burivuhster burivuhster commented Dec 18, 2024

Summary

Added missing iconColor attribute to the LangChain nodes to improve the UI in dark mode.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@burivuhster burivuhster marked this pull request as ready for review December 18, 2024 12:36
Copy link

cypress bot commented Dec 19, 2024

n8n    Run #8415

Run Properties:  status check passed Passed #8415  •  git commit b1c9a44bb4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review ai-499-window-buffer-memory-icon-regression-in-dark-mode
Run status status check passed Passed #8415
Run duration 04m 42s
Commit git commit b1c9a44bb4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 481
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@burivuhster burivuhster merged commit 01b781a into master Dec 19, 2024
37 checks passed
@burivuhster burivuhster deleted the ai-499-window-buffer-memory-icon-regression-in-dark-mode branch December 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants