Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add migration to add managed column to credentials table #12275

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Dec 18, 2024

Summary

Ground work to support free AI credits. See context here.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2995/[n8n-backend]-add-new-column-to-the-credentials-table-to-differentiate

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 requested a review from a team as a code owner December 18, 2024 00:20
@RicardoE105 RicardoE105 changed the title Add migration to add managed column to credentials table feat: Add migration to add managed column to credentials table Dec 18, 2024
@RicardoE105 RicardoE105 requested a review from tomi December 18, 2024 00:23
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@RicardoE105 RicardoE105 requested a review from tomi December 18, 2024 22:51
tomi
tomi previously approved these changes Dec 19, 2024
packages/cli/src/databases/entities/credentials-entity.ts Outdated Show resolved Hide resolved
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@RicardoE105
Copy link
Contributor Author

@tomi thanks for syncing with master 🙏

Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Dec 19, 2024

n8n    Run #8426

Run Properties:  status check failed Failed #8426  •  git commit d2464b5d28: 🌳 feature-sub-workflow-inputs 🖥️ browsers:node18.12.0-chrome107 🤖 milorad 🗃️...
Project n8n
Branch Review feature-sub-workflow-inputs
Run status status check failed Failed #8426
Run duration 04m 08s
Commit git commit d2464b5d28: 🌳 feature-sub-workflow-inputs 🖥️ browsers:node18.12.0-chrome107 🤖 milorad 🗃️...
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 2
Tests that passed  Passing 267
View all changes introduced in this branch ↗︎

Tests for review

Failed  48-subworkflow-inputs.cy.ts • 1 failed test

View Output Video

Test Artifacts
Sub-workflow creation and typed usage > works with type-checked values Test Replay Screenshots Video
Failed  45-workflow-selector-parameter.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  6-code-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  20-workflow-executions.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  30-editor-after-route-changes.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 52 specs in Cypress Cloud.

@RicardoE105 RicardoE105 merged commit 3cb7081 into master Dec 19, 2024
43 of 48 checks passed
@RicardoE105 RicardoE105 deleted the ado-2995-n8n-backend-add-new-column-to-the-credentials-table-to branch December 19, 2024 19:35
riascho pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants