test(Redis Node): Continue on Fail for Redis (no-changelog) #12190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dana-gill
changed the title
dana-gill
force-pushed
the
node-177-redis-tests-continue-on-fail
branch
from
d88bd5f to
d86b989
Compare
dana-gill
force-pushed
the
node-177-redis-tests-continue-on-fail
branch
from
fb24763 to
de13d72
Compare
n8n
|
||||||||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 36s |
| Commit |
|
| Committer | Dana |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
479
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
e2e/45-workflow-selector-parameter.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Workflow Selector Parameter > should render add resource option and redirect to the correct route when clicked |
Test Replay
Screenshots
Video
|
|
e2e/14-mapping.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Data mapping > maps expressions from json view |
Test Replay
Screenshots
Video
|
|
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add tests for continue on fail for Redis. The PR resets mocks instead of clearing them to have a more clean state for testing in Redis.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2147/redis-node-add-tests-and-investigate-success-also-outputting-on-error
Follow up for #11714 (review)
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)