Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (Execute Workflow Node): Inputs for Sub-workflows (#11830) #11837

Merged
merged 42 commits into from
Dec 20, 2024
Merged

feat: (Execute Workflow Node): Inputs for Sub-workflows (#11830) #11837

merged 42 commits into from
Dec 20, 2024

Conversation

igatanasov
Copy link
Contributor

@igatanasov igatanasov commented Nov 21, 2024 •
edited
Loading

Summary

Inputs for Sub-workflows feature branch

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2896/execute-workflow-node-new-node-version-ui-update

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@igatanasov igatanasov self-assigned this Nov 21, 2024
@igatanasov igatanasov added the feature Large self-contained feature label Nov 21, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.14286% with 405 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../nodes/tools/ToolWorkflow/v2/utils/FromAIParser.ts 2.54% 115 Missing ⚠️
...nodes/tools/ToolWorkflow/v1/ToolWorkflowV1.node.ts 0.00% 81 Missing ⚠️
.../workflowInputsResourceMapping/GenericFunctions.ts 23.18% 52 Missing and 1 partial ⚠️
...tools/ToolWorkflow/v2/utils/WorkflowToolService.ts 69.30% 26 Missing and 5 partials ⚠️
...de-execution-context/local-load-options-context.ts 15.38% 22 Missing ⚠️
...i/src/components/ResourceMapper/ResourceMapper.vue 82.79% 15 Missing and 1 partial ⚠️
...nodes/tools/ToolWorkflow/v2/ToolWorkflowV2.node.ts 0.00% 13 Missing ⚠️
packages/editor-ui/src/api/nodeTypes.ts 0.00% 11 Missing ⚠️
...editor-ui/src/composables/useDocumentVisibility.ts 70.58% 10 Missing ⚠️
...li/src/services/dynamic-node-parameters.service.ts 30.76% 8 Missing and 1 partial ⚠️
... and 10 more

📢 Thoughts on this report? Let us know!

CharlieKolb
CharlieKolb reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do link the ticket in the description 🙏

packages/nodes-base/nodes/ExecuteWorkflow/ExecuteWorkflow.node.ts Show resolved Hide resolved
CharlieKolb and others added 13 commits November 26, 2024 12:38
@CharlieKolb
feat(Execute Workflow Trigger Node): Add MVP for explicit input param…
7012d9b 
…eters (#11874)
@CharlieKolb
feat(Execute Workflow Trigger Node): Add types for input fields (#11922)
698f7d0
@CharlieKolb
feat(Execute Workflow Trigger Node): Add JSON-based input modes and d…
001e3f9 
…ropdown (#11946)
@igatanasov
Merge branch 'master' of github.com:n8n-io/n8n into feature-sub-workf…
75a571e 
…low-inputs
@CharlieKolb
fix(Workflow Trigger Node): Display dropdown for V1.1 and up only (#1…
dc400b7 
…2002)
@CharlieKolb
fix(Workflow Trigger Node): Implement Product feedback (#12008)
e2b00a3
@CharlieKolb
feat: Update Example Sub-Workflow (#12000)
2e55cbd
@igatanasov
Merge branch 'master' of github.com:n8n-io/n8n into feature-sub-workf…
8e374b4 
…low-inputs
@igatanasov @CharlieKolb
Ado-2898-execute-workflow-node-add-workflow-inputs-parameter (#11887)
c31bf0a 
Co-authored-by: Charlie Kolb <[email protected]>
@MiloradFilipovic
Merge branch 'master' into feature-sub-workflow-inputs
b6eb5d1
@CharlieKolb
feat(Sub-Workflow Inputs): Add e2e tests for Sub-Workflow Input (#12076)
993581c
@igatanasov
feat(editor): Add map option to preserve field order (#12084)
45dcf99
@MiloradFilipovic
feat(editor): Implement explicit passthrough mode (#12107)
c9f2b16
@igatanasov igatanasov changed the title feat(Execute Workflow Node): Inputs for Sub-workflows (#11830) feat: (Execute Workflow Node): Inputs for Sub-workflows (#11830) Dec 9, 2024
@igatanasov igatanasov force-pushed the feature-sub-workflow-inputs branch from e4a312f to e4d9e7f Compare December 10, 2024 12:21
@cypress Cypress
Copy link

cypress bot commented Dec 20, 2024 •
edited
Loading

n8n    Run #8442

Run Properties:  status check passed Passed #8442  •  git commit 2d4b5f198a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 igatanasov 🗃️ e2e/*
Project n8n
Branch Review feature-sub-workflow-inputs
Run status status check passed Passed #8442
Run duration 04m 47s
Commit git commit 2d4b5f198a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 igatanasov 🗃️ e2e/*
Committer Charlie Kolb
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 483
View all changes introduced in this branch ↗︎

@MiloradFilipovic MiloradFilipovic self-requested a review December 20, 2024 12:52
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

CharlieKolb
CharlieKolb previously approved these changes Dec 20, 2024
View reviewed changes
@MiloradFilipovic MiloradFilipovic self-requested a review December 20, 2024 13:40
@MiloradFilipovic MiloradFilipovic dismissed stale reviews from CharlieKolb and themself via 7b5b93f December 20, 2024 13:48
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@MiloradFilipovic MiloradFilipovic self-requested a review December 20, 2024 13:53
@MiloradFilipovic MiloradFilipovic self-requested a review December 20, 2024 13:59
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit d411663 into master Dec 20, 2024
39 of 40 checks passed
@MiloradFilipovic MiloradFilipovic deleted the feature-sub-workflow-inputs branch December 20, 2024 16:01
riascho pushed a commit that referenced this pull request Dec 23, 2024
@igatanasov @CharlieKolb
@MiloradFilipovic @netroy @riascho
feat: (Execute Workflow Node): Inputs for Sub-workflows (#11830) (#11837
5fe37c0 
)

Co-authored-by: Charlie Kolb <[email protected]>
Co-authored-by: Milorad FIlipović <[email protected]>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiloradFilipovic MiloradFilipovic MiloradFilipovic approved these changes

@CharlieKolb CharlieKolb CharlieKolb left review comments

Assignees

@MiloradFilipovic MiloradFilipovic

@igatanasov igatanasov

@CharlieKolb CharlieKolb

Labels
feature Large self-contained feature n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igatanasov @MiloradFilipovic @CharlieKolb @netroy